Refactor: MUI5, Typescript #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build(config): update config for TS adapt to current standards
refactor: upgrade to MUI5
test(refactor): port tests to Typescript Tests still need some improvements at this point.
When graasp/graasp-apps-query-client#71 will be merged, change back line 17 of package.json: "@graasp/apps-query-client": "github:graasp/graasp-apps-query-client#70-errors-mockApi"
spaenleh
requested changes
Jan 20, 2023
|
You may have to edit the cypress.yml workflow to use the new config file in order for your tests to pass in CI. |
spaenleh
approved these changes
Jan 24, 2023
Co-authored-by: Basile Spaenlehauer <spaenleh@gmail.com>
Co-authored-by: Basile Spaenlehauer <spaenleh@gmail.com>
This was referenced Jan 24, 2023
Co-authored-by: Basile Spaenlehauer <spaenleh@gmail.com>
Remove old and useless deps
add autoresize hook Fix types in multiple components Remove useless messages Remove custom member type def Adapt mock db Co-authored-by: spaenleh
|
@spaenleh, I think I addressed all your comments. I'll merge this afternoon. |
spaenleh
reviewed
Jan 24, 2023
| | { | ||
| deleteAppDataShouldThrow?: boolean | undefined; | ||
| } | ||
| | undefined; |
There was a problem hiding this comment.
You dont need to specify undefined, the object is already marked as ? which is the shorthand for undefined.
There was a problem hiding this comment.
Thanks for paying attention to that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #29
Close #30
Close #23
Close #32