Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event-targets): Adding Event Target Manager construct #106

Merged
merged 1 commit into from
May 5, 2022

Conversation

despock
Copy link
Member

@despock despock commented May 5, 2022

workaround for CDK issue: aws/aws-cdk#17002

Solution for issue which affects the fixed global limit for Log Resource Policies

@despock despock requested a review from jameswiltshire May 5, 2022 23:37
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #106 (f0dc530) into main (00ab578) will decrease coverage by 0.15%.
The diff coverage is 83.72%.

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   94.80%   94.64%   -0.16%     
==========================================
  Files          37       38       +1     
  Lines        5889     5975      +86     
  Branches      202      202              
==========================================
+ Hits         5583     5655      +72     
- Misses        306      320      +14     
Impacted Files Coverage Δ
src/lib/manager/aws/event-target-manager.ts 83.33% <83.33%> (ø)
src/lib/common/construct.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ab578...f0dc530. Read the comment docs.

@despock despock merged commit 4287fd6 into main May 5, 2022
@despock despock deleted the feature/event-target-manager branch May 5, 2022 23:40
@github-actions
Copy link

github-actions bot commented May 5, 2022

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant