Add UninstallTool #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2024
Merged
Merged
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
twindebank
reviewed
Dec 16, 2024
Comment on lines
+20
to
+22
| if err := responseError(rsp); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
nit: could tidy the code a bit if this block were moved inside of makeRequest, seems to be used in the same way every time
There was a problem hiding this comment.
agreed, we can do this separately
twindebank
approved these changes
Dec 16, 2024
nlathia
force-pushed
the
12-16-add_updatetool
branch
from
a2cbe96 to
ec0fb1b
Compare
nlathia
force-pushed
the
12-16-add_uninstalltool
branch
from
171b40b to
6a34e87
Compare
nlathia
changed the base branch from
12-16-add_updatetool
to
graphite-base/34
nlathia
force-pushed
the
12-16-add_uninstalltool
branch
from
6a34e87 to
4bde6b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.