Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Playground to ignore comments in the requirements text #10073

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Nov 29, 2024

Description

Closes #9915

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Nov 29, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/12d83235b900bab2c766521e05fcd62a00a9697c/gradio-5.7.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@12d83235b900bab2c766521e05fcd62a00a9697c#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/12d83235b900bab2c766521e05fcd62a00a9697c/gradio-client-1.8.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/12d83235b900bab2c766521e05fcd62a00a9697c/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
website minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix the Playground to ignore comments in the requirements text

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx whitphx marked this pull request as ready for review November 29, 2024 07:18
Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you @whitphx!

@whitphx whitphx merged commit 873dab5 into main Nov 30, 2024
23 of 24 checks passed
@whitphx whitphx deleted the playground-ignore-requirements-comments branch November 30, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lite Playground: Ignore commented lines in requirements.txt
3 participants