-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3229 styling #3233
3229 styling #3233
Conversation
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3233-all-demos |
I was wrong, removing it seems fine. |
🎉 The demo notebooks match the run.py files! 🎉 |
I couldn't figure out why the test ( I also updated the |
The reason that the test was failing was because one of our dependencies, I've reverted by change to the test since it was useful after all, so my changes to this PR are:
As seen in the deployed Space, LaTeX is now rendering correctly: |
That was fast: executablebooks/mdit-py-plugins#69 |
Description
Closes #3229. Math rendering was actually broken in more ways than that, none of the CSS was applying.
Also removes the z-index from embed error states which were causing issues.
Also adjusted the error message for non-spaces.
Please include:
Closes: # (issue)
Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)
in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)
".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.