-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure frontend functions work when they don't return a value #8521
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/e9b044aa697c604c819be8fd7533913b45e5de93/gradio-4.36.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@e9b044aa697c604c819be8fd7533913b45e5de93#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/e9b044aa697c604c819be8fd7533913b45e5de93/gradio-client-1.1.1.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
The root problem is that |
Yeah I can change that. I'm not sure what other downstream issues it would cause though. This has been the behaviour forever, it just hasn't been erroring until now. |
Actually its probably enough to just type Payload.data as |
I think it's cleaner to always return an array from the frontend function, so I've added some logic for that. Should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome LGTM!
Description
We now expect some kind of value to be passed into a 'submit' even if it is an empty array (no data). This normally happens even where there are no component inputs, the exception to this is when the frontend function returns nothing or a falsey value. Since the return value of the frontend function gets passed into the 'submit' call, this was causing an error.
I have added a default value to the problematic function to address this, and added a few unit tests to prevent regressions.
Closes: #8495
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh