-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dataset update #8581
fix dataset update #8581
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/e7b34a2e270dae09c0808e6be0dd84e7e856cde6/gradio-4.36.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@e7b34a2e270dae09c0808e6be0dd84e7e856cde6#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/e7b34a2e270dae09c0808e6be0dd84e7e856cde6/gradio-client-1.1.1.tgz |
@@ -164,7 +164,7 @@ def flag( | |||
) / client_utils.strip_invalid_filename_characters( | |||
getattr(component, "label", None) or f"component {idx}" | |||
) | |||
if utils.is_update(sample): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a refactor for clarity
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and everything lgtm! Thanks @abidlabs. docs look good too!
Thanks for the prompt review @aliabd! |
Allows the samples in a
gr.Dataset
to be updated. Here's a quick example:Closes: #8312
Closes: #7282
Closes: #6415
Also fixes the issue where clearing an
Interface
that included aDataset
would cause the Interface to crash.Closes: #6807