Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reload mode for jupyter notebook and stateful demos #8599

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Jun 24, 2024

Description

Closes: #8586

Added typechecking to ipython_ext.py as that would have caught the original problem.

reload_jupyter

Closes: #8576

I can't repro the original stacktrace in the issue. But after reloading, the chatbot won't update. See gif below. Updated the e2e test to catch this going forward.

reload_chatbot

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 24, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/9b4bdcf5f8861c1cecd03907bb806ca936f82ed7/gradio-4.36.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@9b4bdcf5f8861c1cecd03907bb806ca936f82ed7#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/9b4bdcf5f8861c1cecd03907bb806ca936f82ed7/gradio-client-1.1.1.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 24, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/app patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix reload mode for jupyter notebook and stateful demos

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton changed the title Fix reload mode for jupyter notebook Fix reload mode for jupyter notebook and stateful demos Jun 24, 2024
@freddyaboulton freddyaboulton marked this pull request as ready for review June 24, 2024 14:10
@freddyaboulton freddyaboulton requested review from pngwn, abidlabs, aliabid94, aliabd, dawoodkhan82 and hannahblair and removed request for pngwn June 24, 2024 14:10
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @freddyaboulton! Confirmed both fixes, thanks for expanding the tests

@abidlabs
Copy link
Member

Let me go ahead and merge this in so that we can do the release soon

@abidlabs abidlabs merged commit ca125b7 into main Jun 25, 2024
8 checks passed
@abidlabs abidlabs deleted the 8586-reload-mode-jupyter branch June 25, 2024 04:36
This was referenced Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot Reload issues in jupyter notebook Gradio reload mode does not work with Chatbot based app
3 participants