Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Spotless minor version and reformat #167

Merged
merged 9 commits into from
Feb 18, 2023
Merged

Upgrade Spotless minor version and reformat #167

merged 9 commits into from
Feb 18, 2023

Commits on Feb 17, 2023

  1. Bump Spotless minor version, in preparation for Gradle 8.0 

    https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.md#690---2022-07-28
    @TWiStErRob
    TWiStErRob committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    0dcc16e View commit details
    Browse the repository at this point in the history

  2. Make Spotless work on Windows.

    @TWiStErRob
    TWiStErRob committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    40ee42b View commit details
    Browse the repository at this point in the history

  3. Remove redundant suppression

    @TWiStErRob
    TWiStErRob committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    2804427 View commit details
    Browse the repository at this point in the history

  4. Remove ktlint rule ignore, it's not failing anymore.

    @TWiStErRob
    TWiStErRob committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    fa09f23 View commit details
    Browse the repository at this point in the history

  5. Disable trailing comma on call-site, 

    because the language version Kotlin 1.3 did not implement this yet.

> Task :compileKotlin FAILED
e: /home/runner/work/publish-plugin/publish-plugin/src/main/kotlin/....kt: (0, 0): The feature "trailing commas" is only available since language version 1.4
    @TWiStErRob
    TWiStErRob committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    440322b View commit details
    Browse the repository at this point in the history

  6. Minor drive-by improvements

    @TWiStErRob
    TWiStErRob committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    489e953 View commit details
    Browse the repository at this point in the history

  7. Go back a bit to support all versions of CI: 

    From 6.13.0 to 6.14.0, Spotless casually dropped Java 8 support:
https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.md#6140---2023-01-26

What is a major change, if inability to use is not 🙄?
    @TWiStErRob
    TWiStErRob committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    e5dfeb0 View commit details
    Browse the repository at this point in the history

  8. Add .gitattributes to ensure that line endings are uniform across pla… 

    …tforms.

Also add .editorconfig entries so IDE doesn't mess with the files.
    @TWiStErRob
    TWiStErRob committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    04747b8 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/master' into spotless_upgrade 

    Conflicts:
	build.gradle.kts
    @TWiStErRob
    TWiStErRob committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    210ede3 View commit details
    Browse the repository at this point in the history