Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix most of configuration cache warnings #223

Merged

Conversation

TWiStErRob
Copy link
Collaborator

@TWiStErRob TWiStErRob commented May 25, 2023

Contributes to #221, but doesn't not fully fix it.

All problems were rooted in this one common place, a captured extension object.

Evidence that all warnings are involved

From configuration-cache report posted here: #221 (comment)

FireShot Capture 001 - Gradle Configuration Cache -

…perty. This helps to remove the captured extension object which results in serializing a lot of unnecessary things.

⌄⚠️cannot serialize object of type org.gradle.api.internal.project.DefaultProject📋, a subtype of org.gradle.api.Project📋, as these are not supported with the configuration cache. ?
⌄field$rootProject📋 of io.github.gradlenexus.publishplugin.NexusPublishPlugin$configureNexusTasks$1📋
⌄bean of type io.github.gradlenexus.publishplugin.NexusPublishPlugin$configureNexusTasks$1📋
⌄fieldval$action📋 of org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1📋
⌄bean of type org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1📋
⌄fielddelegate📋 of org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction📋
⌄bean of type org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction📋
⌄fieldactions📋 of org.gradle.internal.ImmutableActionSet$SetWithFewActions📋
⌄bean of type org.gradle.internal.ImmutableActionSet$SetWithFewActions📋
⌄fieldaddActions📋 of org.gradle.api.internal.collections.DefaultCollectionEventRegister📋
⌄bean of type org.gradle.api.internal.collections.DefaultCollectionEventRegister📋
⌄fieldeventRegister📋 of org.gradle.api.internal.FactoryNamedDomainObjectContainer📋
⌄bean of type org.gradle.api.internal.FactoryNamedDomainObjectContainer📋
⌄field$$delegate_0📋 of io.github.gradlenexus.publishplugin.DefaultNexusRepositoryContainer📋
⌄bean of type io.github.gradlenexus.publishplugin.DefaultNexusRepositoryContainer📋
⌄fieldrepositories📋 of io.github.gradlenexus.publishplugin.NexusPublishExtension📋
⌄bean of type io.github.gradlenexus.publishplugin.NexusPublishExtension📋
⌄field$extension📋 of io.github.gradlenexus.publishplugin.AbstractNexusStagingRepositoryTask$1📋
⌄bean of type io.github.gradlenexus.publishplugin.AbstractNexusStagingRepositoryTask$1📋
⌄fieldspec📋 of org.gradle.api.internal.tasks.execution.SelfDescribingSpec📋
⌄bean of type org.gradle.api.internal.tasks.execution.SelfDescribingSpec📋
⌄fieldspecs📋 of org.gradle.api.specs.AndSpec📋
⌄bean of type org.gradle.api.specs.AndSpec📋
⌄fieldspecHolder📋 of org.gradle.api.internal.tasks.execution.DescribingAndSpec📋
⌄bean of type org.gradle.api.internal.tasks.execution.DescribingAndSpec📋
⌄fieldonlyIfSpec📋 of io.github.gradlenexus.publishplugin.InitializeNexusStagingRepository📋
■task:initializeMyNexusStagingRepository📋 of type io.github.gradlenexus.publishplugin.InitializeNexusStagingRepository📋
⌄field$rootProject📋 of io.github.gradlenexus.publishplugin.NexusPublishPlugin$configureNexusTasks$2📋
⌄bean of type io.github.gradlenexus.publishplugin.NexusPublishPlugin$configureNexusTasks$2📋
⌄fieldval$action📋 of org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1📋
⌄bean of type org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1📋
⌄fielddelegate📋 of org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction📋
⌄bean of type org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction📋
⌄fieldsingleAction📋 of org.gradle.internal.ImmutableActionSet$SingletonSet📋
⌄bean of type org.gradle.internal.ImmutableActionSet$SingletonSet📋
⌄fieldremoveActions📋 of org.gradle.api.internal.collections.DefaultCollectionEventRegister📋
⌄bean of type org.gradle.api.internal.collections.DefaultCollectionEventRegister📋
⌄fieldeventRegister📋 of org.gradle.api.internal.FactoryNamedDomainObjectContainer📋
⌄bean of type org.gradle.api.internal.FactoryNamedDomainObjectContainer📋
⌄field$$delegate_0📋 of io.github.gradlenexus.publishplugin.DefaultNexusRepositoryContainer📋
⌄bean of type io.github.gradlenexus.publishplugin.DefaultNexusRepositoryContainer📋
⌄fieldrepositories📋 of io.github.gradlenexus.publishplugin.NexusPublishExtension📋
⌄bean of type io.github.gradlenexus.publishplugin.NexusPublishExtension📋
⌄field$extension📋 of io.github.gradlenexus.publishplugin.AbstractNexusStagingRepositoryTask$1📋
⌄bean of type io.github.gradlenexus.publishplugin.AbstractNexusStagingRepositoryTask$1📋
⌄fieldspec📋 of org.gradle.api.internal.tasks.execution.SelfDescribingSpec📋
⌄bean of type org.gradle.api.internal.tasks.execution.SelfDescribingSpec📋
⌄fieldspecs📋 of org.gradle.api.specs.AndSpec📋
⌄bean of type org.gradle.api.specs.AndSpec📋
⌄fieldspecHolder📋 of org.gradle.api.internal.tasks.execution.DescribingAndSpec📋
⌄bean of type org.gradle.api.internal.tasks.execution.DescribingAndSpec📋
⌄fieldonlyIfSpec📋 of io.github.gradlenexus.publishplugin.InitializeNexusStagingRepository📋
■task:initializeMyNexusStagingRepository📋 of type io.github.gradlenexus.publishplugin.InitializeNexusStagingRepository📋
⌄field$rootProject📋 of io.github.gradlenexus.publishplugin.NexusPublishPlugin$configureSimplifiedCloseAndReleaseTask$2📋
⌄bean of type io.github.gradlenexus.publishplugin.NexusPublishPlugin$configureSimplifiedCloseAndReleaseTask$2📋
⌄fieldval$action📋 of org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1📋
⌄bean of type org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1📋
⌄fielddelegate📋 of org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction📋
⌄bean of type org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction📋
⌄fieldactions📋 of org.gradle.internal.ImmutableActionSet$SetWithFewActions📋
⌄bean of type org.gradle.internal.ImmutableActionSet$SetWithFewActions📋
⌄fieldaddActions📋 of org.gradle.api.internal.collections.DefaultCollectionEventRegister📋
⌄bean of type org.gradle.api.internal.collections.DefaultCollectionEventRegister📋
⌄fieldeventRegister📋 of org.gradle.api.internal.FactoryNamedDomainObjectContainer📋
⌄bean of type org.gradle.api.internal.FactoryNamedDomainObjectContainer📋
⌄field$$delegate_0📋 of io.github.gradlenexus.publishplugin.DefaultNexusRepositoryContainer📋
⌄bean of type io.github.gradlenexus.publishplugin.DefaultNexusRepositoryContainer📋
⌄fieldrepositories📋 of io.github.gradlenexus.publishplugin.NexusPublishExtension📋
⌄bean of type io.github.gradlenexus.publishplugin.NexusPublishExtension📋
⌄field$extension📋 of io.github.gradlenexus.publishplugin.AbstractNexusStagingRepositoryTask$1📋
⌄bean of type io.github.gradlenexus.publishplugin.AbstractNexusStagingRepositoryTask$1📋
⌄fieldspec📋 of org.gradle.api.internal.tasks.execution.SelfDescribingSpec📋
⌄bean of type org.gradle.api.internal.tasks.execution.SelfDescribingSpec📋
⌄fieldspecs📋 of org.gradle.api.specs.AndSpec📋
⌄bean of type org.gradle.api.specs.AndSpec📋
⌄fieldspecHolder📋 of org.gradle.api.internal.tasks.execution.DescribingAndSpec📋
⌄bean of type org.gradle.api.internal.tasks.execution.DescribingAndSpec📋
⌄fieldonlyIfSpec📋 of io.github.gradlenexus.publishplugin.InitializeNexusStagingRepository📋
■task:initializeMyNexusStagingRepository📋 of type io.github.gradlenexus.publishplugin.InitializeNexusStagingRepository📋
@szpak szpak merged commit 3ac012c into gradle-nexus:master Jun 2, 2023
@szpak szpak added this to the 2.0.0 milestone Jun 5, 2023
@TWiStErRob TWiStErRob deleted the configuration-cache-fix-warnings branch July 8, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants