Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reviewed list of gradle books - proposal for books.md #111

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ivonasto
Copy link
Contributor

Books metadata file with existing titles in English from the 2020 list in issue #98.

Images to be added.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @ivonasto! We can merge the first version without the images, but we will still need books.html to be added to the page. Also, please add the page to the navigation under the Resources section

@oleg-nenashev oleg-nenashev added the documentation Improvements or additions to documentation label Oct 14, 2024
@oleg-nenashev
Copy link
Member

Hi @ivonasto , do you plan to finish this PR? Or is any help needed?

@ivonasto
Copy link
Contributor Author

Hi, @oleg-nenashev. Yes, I will finish it. I have trouble with the dev container, almost got it working. I have more time now to look into it. Thank you

@oleg-nenashev
Copy link
Member

Sure. If you need any help with sorting the issue, just ask on the #docs or #contributing Slack channels

@ivonasto
Copy link
Contributor Author

Hello, I did the preliminary version. If you have any visual or code suggestions, please let me know.

Could you upload the book covers so I can replace the placeholder image?

@oleg-nenashev
Copy link
Member

Since it is deployed from the main branch, good opportunity to do a preview implementation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants