Buildmutators filter removal #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlexBeggs
commented
Feb 8, 2021
AlexBeggs
commented
- remove the key filtering from the ScenarioLoader outside of the BuildMutators
- update existing BuildMutators to return NOOP when key doesn't exist in config, allowing the BuildMutators to be responsible for enabling/disabling functionality. This will allow BuildMutators to work with specific Build types (ie Bazel) or all of them depending on the configuration.
AlexBeggs
force-pushed
the
buildmutators-filter-removal
branch
from
c23a7ad to
637e955
Compare
AlexBeggs
commented
Feb 8, 2021
| @@ -212,7 +212,6 @@ public ScenarioLoader(GradleBuildConfigurationReader gradleBuildConfigurationRea | |||
| String title = scenario.hasPath(TITLE) ? scenario.getString(TITLE) : null; | |||
|
|
|||
| List<BuildMutator> mutators = BUILD_MUTATOR_CONFIGURATORS.entrySet().stream() | |||
| .filter(entry -> scenario.hasPath(entry.getKey())) | |||
There was a problem hiding this comment.
BuildMutators are responsible for returning BuildMutator.NOOP if they don't support this key during configuration. This centralizes the logic to the BuildMutator instead of in 2 places.
AlexBeggs
force-pushed
the
buildmutators-filter-removal
branch
from
637e955 to
c7db586
Compare
- remove the key filtering from the ScenarioLoader outside of the BuildMutators - update existing BuildMutators to return NOOP when key doesn't exist in config, allowing the BuildMutators to be responsible for enabling/disabling functionality. This will allow BuildMutators to work with specific Build types (ie Bazel) or all of them depending on the configuration. Signed-off-by: Alex Beggs <sunyal@gmail.com>
AlexBeggs
force-pushed
the
buildmutators-filter-removal
branch
from
c7db586 to
91030d3
Compare
|
@lptr any word on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.