-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds fail if root project is in root of mount point, with further implications #15655
Comments
Verified this happens as described. |
We do recommend Gradle users to specify the root project name in the settings script, so it might make sense to make it required. At the same time, I think there would be a lot of users who would come to this issue and argue that they actually prefer simplicity. We could also tackle this issue by setting a conventional name ( |
Also assigns 'root' if the name is empty. Fixes #15655
- fixes #15655 Signed-off-by: Reinhold Degenfellner <rdegenfellner@gradle.com>
- generate random part - fixes #15655 Signed-off-by: Reinhold Degenfellner <rdegenfellner@gradle.com>
- part of #15655 Signed-off-by: Reinhold Degenfellner <rdegenfellner@gradle.com>
- part of #15655 Signed-off-by: Reinhold Degenfellner <rdegenfellner@gradle.com>
- generate random part - fixes #15655 Signed-off-by: Reinhold Degenfellner <rdegenfellner@gradle.com>
- part of #15655 Signed-off-by: Reinhold Degenfellner <rdegenfellner@gradle.com>
- part of #15655 Signed-off-by: Reinhold Degenfellner <rdegenfellner@gradle.com>
- fixes #15655 Co-authored-by: Reinhold Degenfellner <rdegenfellner@gradle.com>
Building any project in a root mount point (e.g.
C:/
for Windows or/
for *nix) fails unlesssettings.gradle
has arootProject.name=
value specified.Expected Behavior
Gradle should not be smart about the project name, by deducing it from the directory name, but it should be specified explicitly. Especially, this is problematic in a multi-developer environment where the project name can vary greatly depending on what developers are naming their clone directories, and it will affect what's getting reported to Gradle Enterprise, thereby polluting data.
I suppose it could be discouraged as a deprecation, then to be disallowed in a future major release.
Current Behavior
Context
This was causing issues when I mounted a shared folder in a Windows VirtualBox environment.
Steps to Reproduce
$ gradle -p / --project-cache-dir=$HOME
Your Environment
OS: Windows/macOS
Gradle: 6.8-rc-4
The text was updated successfully, but these errors were encountered: