Bump node_exporter version to v1.5.0 #2629
Conversation
|
|
|
Hey there, thanks for the PR! 👋 Just a small note, the version listed in the go.mod file Could you also take a look at the failing test and mention the new collectors that were introduced in node_exporter's 1.4.0 in our documentation? |
Thor77
requested review from
karengermond,
rgeyer,
gaantunes,
captncraig and
marctc
as code owners
|
@tpaschalis Thanks for taking a look! The test is failing because the flag is available for Darwin now (collector was refactored in prometheus/node_exporter#2417). |
|
Hey Jonas! This looks reasonable at a first glance, but would like to sanity check it. Just a heads up, reviews might be a little slower due to most of the reviewers being away on PTO, but it shouldn't be too long! |
| DiskStatsIgnoredDevices string `yaml:"diskstats_ignored_devices,omitempty"` | ||
| DiskStatsDeviceExclude string `yaml:"diskstats_device_exclude,omitempty"` | ||
| DiskStatsDeviceInclude string `yaml:"diskstats_device_include,omitempty"` |
There was a problem hiding this comment.
This would be considered a breaking change, so we'd need to document it as such in the upgrade guide.
There was a problem hiding this comment.
This shouldn't be breaking because there's a migration from the old to the new value. But I added a note to the changelog and upgrade-guide and also rebased on main to resolve the merge conflict.
Thor77
force-pushed
the
update-node-exporter
branch
from
fe4eff3
to
e73ae22
Compare
| @@ -127,6 +128,8 @@ type Config struct { | |||
| PowersupplyIgnoredSupplies string `yaml:"powersupply_ignored_supplies,omitempty"` | |||
| RunitServiceDir string `yaml:"runit_service_dir,omitempty"` | |||
| SupervisordURL string `yaml:"supervisord_url,omitempty"` | |||
| SysctlInclude flagext.StringSlice `yaml:"sysctl_include,omitempty"` | |||
There was a problem hiding this comment.
Probably we want to expose this values here too: component/prometheus/integration/node_exporter/config.go
There was a problem hiding this comment.
added and also rebased again because of the merge conflicts in go.mod
the --ignored-devices flag was removed and replaced by --device-exclude and --device-include
Thor77
force-pushed
the
update-node-exporter
branch
from
e73ae22
to
5a754b8
Compare
CHANGELOG.md
Outdated
| @@ -25,6 +26,10 @@ v0.31.0-rc.0 (2023-01-26) | |||
| - `agentctl` is now `grafana-agentctl`. | |||
| - `agent-operator` is now `grafana-agent-operator`. | |||
|
|
|||
| - Node Exporter configuration options changed to align with new upstream version (@Thor77): | |||
There was a problem hiding this comment.
This should be in Main (unreleased) section
There was a problem hiding this comment.
Oh, I messed this up while rebasing, fixed.
Fixes issue introduced by grafana#2629
* Flow: support reloading when receiving a SIGHUP This matches the behavior of the static mode. * deb, rpm: respond to `systemctl reload grafana-agent` Send a SIGHUP signal to Grafana Agent when `systemctl reload grafana-agent` is invoked. * update CHANGELOG * fix broken river stanza in prometheus.integration.node_exporter Fixes issue introduced by #2629
github-actions
bot
added
the
frozen-due-to-age
PR Description
Update node_exporter integration to v1.5.0
Specific reason for the update: in v1.3.1 the zfs_zpool_state metric is not available with my ZFS version, prometheus/node_exporter#2451 solves that issue and is included in v1.4.0.
PR Checklist