docker: build using distroless image #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npazosmendez
approved these changes
Dec 4, 2024
Dockerfile
Outdated
| @@ -1,8 +1,15 @@ | |||
| FROM alpine | |||
| FROM alpine as groupbuilder | |||
There was a problem hiding this comment.
I'd name this builder maybe
There was a problem hiding this comment.
and the as should be AS otherwise some other linter will complain
There was a problem hiding this comment.
renamed and rebased, good call
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
jesusvazquez
force-pushed
the
jvp/distroless-image
branch
from
1d47d33 to
17618ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the dockerfile to use alpine as the builder image but base the final carbon-relay-ng image on a distroless image