fixup! fixup! Execute health checks for ring clients in parallel

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
grafana · Dec 7, 2022 · 6251548 · 6251548
1 parent 1b6abd2
commit 6251548
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/ring/client/pool.go b/ring/client/pool.go
@@ -39,7 +39,7 @@ type PoolConfig struct {
 	CheckInterval             time.Duration
 	HealthCheckEnabled        bool
 	HealthCheckTimeout        time.Duration
-	MaxConcurrentHealthChecks int
+	MaxConcurrentHealthChecks int // defaults to 16
 }
 
 // Pool holds a cache of grpc_health_v1 clients.

diff --git a/ring/client/pool_test.go b/ring/client/pool_test.go
@@ -3,7 +3,6 @@ package client
 import (
 	"context"
 	"fmt"
-	"os"
 	"testing"
 	"time"
 
@@ -144,7 +143,7 @@ func TestCleanUnhealthy(t *testing.T) {
 				CheckInterval:             1 * time.Second,
 				HealthCheckTimeout:        5 * time.Millisecond,
 			}
-			pool := NewPool("test", cfg, nil, nil, nil, log.NewLogfmtLogger(os.Stderr))
+			pool := NewPool("test", cfg, nil, nil, nil, log.NewNopLogger())
 			pool.clients = clients
 			pool.cleanUnhealthy()