Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorize grpc_client config #125

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Categorize grpc_client config #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backoff/backoff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ import (

// Config configures a Backoff
type Config struct {
MinBackoff time.Duration `yaml:"min_period"` // start backoff at this level
MaxBackoff time.Duration `yaml:"max_period"` // increase exponentially to this level
MaxRetries int `yaml:"max_retries"` // give up after this many; zero means infinite retries
MinBackoff time.Duration `yaml:"min_period" category:"advanced"` // start backoff at this level
MaxBackoff time.Duration `yaml:"max_period" category:"advanced"` // increase exponentially to this level
MaxRetries int `yaml:"max_retries" category:"advanced"` // give up after this many; zero means infinite retries
}

// RegisterFlagsWithPrefix for Config.
Expand Down
12 changes: 6 additions & 6 deletions grpcclient/grpcclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ import (

// Config for a gRPC client.
type Config struct {
MaxRecvMsgSize int `yaml:"max_recv_msg_size"`
MaxSendMsgSize int `yaml:"max_send_msg_size"`
GRPCCompression string `yaml:"grpc_compression"`
RateLimit float64 `yaml:"rate_limit"`
RateLimitBurst int `yaml:"rate_limit_burst"`
MaxRecvMsgSize int `yaml:"max_recv_msg_size" category:"advanced"`
MaxSendMsgSize int `yaml:"max_send_msg_size" category:"advanced"`
GRPCCompression string `yaml:"grpc_compression" category:"advanced"`
RateLimit float64 `yaml:"rate_limit" category:"advanced"`
RateLimitBurst int `yaml:"rate_limit_burst" category:"advanced"`

BackoffOnRatelimits bool `yaml:"backoff_on_ratelimits"`
BackoffOnRatelimits bool `yaml:"backoff_on_ratelimits" category:"advanced"`
BackoffConfig backoff.Config `yaml:"backoff_config"`

TLSEnabled bool `yaml:"tls_enabled" category:"advanced"`
Expand Down