refactor(Tracking): Better error logging for Scenes variables #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test coverage
|
grafakus
commented
Nov 20, 2024
| logger.error(error as Error, { | ||
| info: 'Error while loading Pyroscope label values!', | ||
| variableName: variableName || '', | ||
| }); |
There was a problem hiding this comment.
Here we don't rethrow, we degrade gracefully so the UI can render something (hopefully) useful for the user.
Once @bryanhuhta can continue on grafana/pyroscope#3563, we can remove all this logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Related issue(s):
-When a Scene variable encounters an error, the Scenes library only sets the error message in the variable state. This PR ensures we log an error with Faro, and not only the message.
Additionally, there's a of behaviour for the "Labels" view: we prevent the labels data source to fail when fetching label values fail.
📖 Summary of the changes
The logger calls are moved to the data sources instead of the React components. See diff tab for specific comments.
🧪 How to test?
-