Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Move PublishConfig properties #41

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Conversation

jackw
Copy link
Contributor

@jackw jackw commented Apr 18, 2023

I noticed you're making use of publishConfig to set package.json properties which is only supported by yarn berry and pnpm.

Given the package.json always points at dist there's no need to migrate to either of these package managers and we can move the properties out to allow consuming projects to make use of the esm builds.

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jackw
Copy link
Contributor Author

jackw commented Apr 24, 2023

Thanks for the reviews. I'm afraid I'm not familiar with this repo and cannot find any instructions on how versioning and publishing is handled. Could someone more familiar take over this PR to get the changes released please? 🙂

@sarahzinger
Copy link
Member

@jackw no problem, will release a new version today, thanks for the contribution!

@sarahzinger sarahzinger merged commit 60f4c81 into main Apr 24, 2023
@sarahzinger sarahzinger deleted the jackw/fix-publish-config branch April 24, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants