Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create github release on new version only #86

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

kevinwcyu
Copy link
Contributor

Fixes: #83

Runs the Create GitHub Release only if the version has changed

@kevinwcyu kevinwcyu requested a review from a team as a code owner June 10, 2024 22:01
@kevinwcyu kevinwcyu requested review from iwysiu and sarahzinger and removed request for a team June 10, 2024 22:01
Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 lol what's been happening all this time if not this lol

@kevinwcyu
Copy link
Contributor Author

👀 lol what's been happening all this time if not this lol

The github release was trying to create a new tag and release on every merge to main, even if the package.json version was not changed. so errors like this would happen because there isn't a new version and we try to publish a tag v

tag_name: "v${{ needs.npm-publish.outputs.new_version }}",
.

@kevinwcyu kevinwcyu merged commit 8cbf1af into main Jun 11, 2024
3 checks passed
@kevinwcyu kevinwcyu deleted the kevinwcyu/fix-github-release-workflow branch June 11, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix workflow to detect version change
2 participants