Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the repo in two #26

Closed
Tracked by #28
sunker opened this issue Oct 21, 2021 · 4 comments · Fixed by #35
Closed
Tracked by #28

Split the repo in two #26

sunker opened this issue Oct 21, 2021 · 4 comments · Fixed by #35

Comments

@sunker
Copy link
Collaborator

sunker commented Oct 21, 2021

It makes no sense to have both frontend and backend code in this repo since they don't share code, settings or version numbers. We should therefore move the frontend code and frontend tooling to a new repo - grafana-aws-sdk-js (or something). The backend code can be kept in this repo, but the repo should be renamed to grafana-aws-sdk-go.

Somewhat related to #27.

@andresmgot
Copy link
Contributor

I think it's not that easy to rename this repo, the golang path would change, causing a breaking change for the packages using this. I think we can leave this repo as it is and move JS code to a different repo.

@sunker
Copy link
Collaborator Author

sunker commented Nov 1, 2021

Yep that's totally fine!

@ryantxu
Copy link
Member

ryantxu commented Nov 8, 2021

I suppose it is fine -- and we are already dealing with a mass of repos, so 🤷‍♂️

the fact that they don't share any code is a bit orthogonal to the fact that both projects are used together. The frontend+backend need to work with and produce objects that work together.

Is there something I am not thinking of that makes this actually better to have managed in two places rather than one?

@andresmgot
Copy link
Contributor

Is there something I am not thinking of that makes this actually better to have managed in two places rather than one?

Replied at #35 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants