-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove backend code #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
.eslintrc
Outdated
"no-only-tests/no-only-tests": "error", | ||
"react/prop-types": "off", | ||
"@emotion/jsx-import": "error", | ||
"lodash/import-scope": [2, "member"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious what inspired the need to extend what we have? Seems like we'd want to keep things more or less in line with whatever the defaults right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied this from the root of grafana/grafana but I guess it's not really that needed. I can just use the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you thought about publishing? I think this solution is pretty neat. It published a new version every time a PR is merged to main and it includes changes to the version prop.
@@ -32,7 +32,7 @@ func Drone() error { | |||
return err | |||
} | |||
|
|||
if err := sh.RunV("drone", "--server", "https://drone.grafana.net", "sign", "--save", "grafana/grafana-plugin-sdk-go"); err != nil { | |||
if err := sh.RunV("drone", "--server", "https://drone.grafana.net", "sign", "--save", "grafana/grafana-aws-sdk-react"); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to have this file for Drone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, it was just out of convenience to not having to remember the whole drone command but I can just add it to the docs.
Thanks for the pointer! Yes, I was thinking on adding that when releasing but I can add it to this PR. |
Leave this repository as frontend only.
Issue: grafana/grafana-aws-sdk#26