Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore: Click on prometheus table result to filter does nothing #17071

Closed
davkal opened this issue May 14, 2019 · 2 comments · Fixed by #17083
Closed

Explore: Click on prometheus table result to filter does nothing #17071

davkal opened this issue May 14, 2019 · 2 comments · Fixed by #17083
Assignees
@hugohaggmark
Labels
area/explore datasource/Prometheus type/bug
Milestone
6.2.1

Comments

@davkal
Copy link
Contributor

davkal commented May 14, 2019

What happened:

Tried to filter a prometheus query by clicking on a table cell.

What you expected to happen:

Clicked label to be added to the query.

How to reproduce it (as minimally and precisely as possible):

  1. Prom datasource in Explore
  2. query up
  3. Click on a label value in the result table.

Result: query is not changed.

Anything else we need to know?:

This used to work.
@torkelo
Copy link
Member

torkelo commented May 14, 2019

Can you test on play as well so we know if it affects 6.2 beta as well

@torkelo torkelo added this to the 6.2.0 milestone May 14, 2019
@torkelo
Copy link
Member

torkelo commented May 14, 2019

This seems to impact 6.2 as well so adding this to 6.2 stable milestone

@hugohaggmark hugohaggmark self-assigned this May 15, 2019
hugohaggmark added a commit that referenced this issue May 15, 2019
@hugohaggmark
Fix: Fixes filtering in Prometheus queries when clicking in Table
6103793 
Fixes: #17071
@hugohaggmark hugohaggmark mentioned this issue May 15, 2019
Merged
torkelo pushed a commit that referenced this issue May 15, 2019
@hugohaggmark @torkelo
Explore: Fixes filtering in Prometheus queries when clicking in Table (…
fdd421e 
…#17083)

Fixes: #17071
@torkelo torkelo modified the milestones: 6.2.0-beta2, 6.2.1 May 23, 2019
@torkelo torkelo mentioned this issue May 23, 2019
Closed
marefr pushed a commit that referenced this issue May 27, 2019
@hugohaggmark @marefr
Explore: Fixes filtering in Prometheus queries when clicking in Table (…
4c09c33 
…#17083)

Fixes: #17071
(cherry picked from commit fdd421e)
marefr pushed a commit that referenced this issue May 27, 2019
@hugohaggmark @marefr
Explore: Fixes filtering in Prometheus queries when clicking in Table (…
ad7bd88 
…#17083)

Fixes: #17071
(cherry picked from commit fdd421e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hugohaggmark hugohaggmark

Labels
area/explore datasource/Prometheus type/bug
Projects
None yet
Milestone
6.2.1
3 participants
@torkelo @hugohaggmark @davkal