Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphite: Fixes issue with seriesByTag & function with variable param #17795

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Jun 27, 2019

Query with seriesByTag & a function with a variable param was parsed incorrectly into the view model and hence rendered incorrectly back to the query string.

Fixes #17696

@torkelo torkelo merged commit 8fcc370 into master Jun 27, 2019
@torkelo torkelo deleted the graphite-query-model-fix branch June 27, 2019 12:10
@torkelo torkelo added this to the 6.3.0-beta1 milestone Jun 27, 2019
ryantxu added a commit to ryantxu/grafana that referenced this pull request Jun 27, 2019
* grafana/master:
  noImplicitAny: Lower count to about 3450 (grafana#17799)
  Graphite: Fixes issue with seriesByTag & function with variable param (grafana#17795)
  noImplicitAny: Reduce errors to 3800-ish (grafana#17781)
  Graphite: remove feature that moves alias function last (grafana#17791)
  Explore: Adds URL support for select mode (grafana#17755)
  TestData: add option to increase the number of test streams (grafana#17789)
  Usage Stats: Update known datasource plugins (grafana#17787)
  Docs: Adds section on Querying Logs for Elasticsearch (grafana#17730)
  Docs: Adds section on Querying Logs for InfluxDB (grafana#17726)
  Devenv: makes the grafana users default for saml. (grafana#17782)
  Explore: Displays only one Time column as configured in TimeZone settings (grafana#17775)
  Markdown: Replace rendering library (grafana#17686)
  ApiKeys: Fix check for UTC timezone (grafana#17776)
  Prometheus: Minor style fix (grafana#17773)
  Docs: fixed notifications table
  Auth: Allow expiration of API keys (grafana#17678)
  17278 prometheus step align utc (grafana#17477)
  Docs: Update release guide  (grafana#17759)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Jun 27, 2019
…-mapping-to-field

* grafana/master: (35 commits)
  noImplicitAny: Lower count to about 3450 (grafana#17799)
  Graphite: Fixes issue with seriesByTag & function with variable param (grafana#17795)
  noImplicitAny: Reduce errors to 3800-ish (grafana#17781)
  Graphite: remove feature that moves alias function last (grafana#17791)
  Explore: Adds URL support for select mode (grafana#17755)
  TestData: add option to increase the number of test streams (grafana#17789)
  Usage Stats: Update known datasource plugins (grafana#17787)
  Docs: Adds section on Querying Logs for Elasticsearch (grafana#17730)
  Docs: Adds section on Querying Logs for InfluxDB (grafana#17726)
  Devenv: makes the grafana users default for saml. (grafana#17782)
  Explore: Displays only one Time column as configured in TimeZone settings (grafana#17775)
  Markdown: Replace rendering library (grafana#17686)
  ApiKeys: Fix check for UTC timezone (grafana#17776)
  Prometheus: Minor style fix (grafana#17773)
  Docs: fixed notifications table
  Auth: Allow expiration of API keys (grafana#17678)
  17278 prometheus step align utc (grafana#17477)
  Docs: Update release guide  (grafana#17759)
  release: update latest.json to v6.2.5 (grafana#17767)
  release: 6.2.5 changelog (grafana#17766)
  ...
markelog added a commit to markelog/grafana that referenced this pull request Jun 29, 2019
* master: (47 commits)
  Elasticsearch: Fix default max concurrent shard requests (grafana#17770)
  Explore: Fix filter by series level in logs graph (grafana#17798)
  Docs: Add v6.3 version notes and encryption format information (grafana#17825)
  Graphite: use POST for /metrics/find requests (grafana#17814)
  Dashboard: Force update after dashboard resize (grafana#17808)
  Toolkit: moved front end cli scripts to separate package and introduced very early version of plugin tools
  Explore: Uses new TimePicker from Grafana/UI (grafana#17793)
  Explore: Uses RFC3339Nano string to retrieve LogRow contexts from Loki API (grafana#17813)
  noImplicitAny: Lower count to about 3450 (grafana#17799)
  Graphite: Fixes issue with seriesByTag & function with variable param (grafana#17795)
  noImplicitAny: Reduce errors to 3800-ish (grafana#17781)
  Graphite: remove feature that moves alias function last (grafana#17791)
  Explore: Adds URL support for select mode (grafana#17755)
  TestData: add option to increase the number of test streams (grafana#17789)
  Usage Stats: Update known datasource plugins (grafana#17787)
  Docs: Adds section on Querying Logs for Elasticsearch (grafana#17730)
  Docs: Adds section on Querying Logs for InfluxDB (grafana#17726)
  Devenv: makes the grafana users default for saml. (grafana#17782)
  Explore: Displays only one Time column as configured in TimeZone settings (grafana#17775)
  Markdown: Replace rendering library (grafana#17686)
  ...
xlson added a commit to xlson/grafana that referenced this pull request Jul 1, 2019
* master: (69 commits)
  Elasticsearch: Fix default max concurrent shard requests (grafana#17770)
  Explore: Fix filter by series level in logs graph (grafana#17798)
  Docs: Add v6.3 version notes and encryption format information (grafana#17825)
  Graphite: use POST for /metrics/find requests (grafana#17814)
  Dashboard: Force update after dashboard resize (grafana#17808)
  Toolkit: moved front end cli scripts to separate package and introduced very early version of plugin tools
  Explore: Uses new TimePicker from Grafana/UI (grafana#17793)
  Explore: Uses RFC3339Nano string to retrieve LogRow contexts from Loki API (grafana#17813)
  noImplicitAny: Lower count to about 3450 (grafana#17799)
  Graphite: Fixes issue with seriesByTag & function with variable param (grafana#17795)
  noImplicitAny: Reduce errors to 3800-ish (grafana#17781)
  Graphite: remove feature that moves alias function last (grafana#17791)
  Explore: Adds URL support for select mode (grafana#17755)
  TestData: add option to increase the number of test streams (grafana#17789)
  Usage Stats: Update known datasource plugins (grafana#17787)
  Docs: Adds section on Querying Logs for Elasticsearch (grafana#17730)
  Docs: Adds section on Querying Logs for InfluxDB (grafana#17726)
  Devenv: makes the grafana users default for saml. (grafana#17782)
  Explore: Displays only one Time column as configured in TimeZone settings (grafana#17775)
  Markdown: Replace rendering library (grafana#17686)
  ...
ryantxu added a commit to ryantxu/grafana that referenced this pull request Jul 1, 2019
* grafana/master: (35 commits)
  Refactor: rename SeriesData to DataFrame (grafana#17854)
  devenv: switch OpenTSDB docker block (grafana#17849)
  Devenv:LDAP: couple simplifications for LDAP (grafana#17807)
  Login: divide login errors by pkg and service (grafana#17835)
  Auth Proxy: Respect auto_sign_up setting (grafana#17843)
  OAuth: return github teams as a part of user info (enable team sync) (grafana#17797)
  noImplicitAny: Sub 3000 errors (grafana#17821)
  TimePicker: Style and responsive fixes, restored dashboard settings (grafana#17822)
  Templating: Correctly display __text in multi-values variable (grafana#17840)
  Elasticsearch: Fix default max concurrent shard requests (grafana#17770)
  Explore: Fix filter by series level in logs graph (grafana#17798)
  Docs: Add v6.3 version notes and encryption format information (grafana#17825)
  Graphite: use POST for /metrics/find requests (grafana#17814)
  Dashboard: Force update after dashboard resize (grafana#17808)
  Toolkit: moved front end cli scripts to separate package and introduced very early version of plugin tools
  Explore: Uses new TimePicker from Grafana/UI (grafana#17793)
  Explore: Uses RFC3339Nano string to retrieve LogRow contexts from Loki API (grafana#17813)
  noImplicitAny: Lower count to about 3450 (grafana#17799)
  Graphite: Fixes issue with seriesByTag & function with variable param (grafana#17795)
  noImplicitAny: Reduce errors to 3800-ish (grafana#17781)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphite Query editor breaks queries when editing (using graphite with tags)
1 participant