PhantomJS: Fixes rendering on Debian Buster #18162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
approved these changes
Jul 20, 2019
|
Tested this on our latest docker image, and ubuntu 16 & RHEL 7 and I could render png graphs just fine |
ryantxu
added a commit
that referenced
this pull request
Jul 23, 2019
* origin/master: Typo: fix threshodsWithoutKey (#18228) alerting: more specific error when missing threshold (#18221) Graph: fix time label description for datalink suggestions (#18214) Explore: Reduce default time range to last hour (#18212) alerting: return err when SetAlertState fails to save to sql (#18216) PhantomJS: Fixes rendering on Debian Buster (#18162) Docs: sudo is required on the apt-key add not on wget (#18180) Build: watch and dev mode webpack improvements (#18153) Plugin: AzureMonitor - Reapply MetricNamespace support (#17282)
xlson
added a commit
that referenced
this pull request
Jul 26, 2019
xlson
added a commit
that referenced
this pull request
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Attempt for a workaround for PhantomJS problems on Debian Buster (that was just released)
Which issue(s) this PR fixes:
Fixes #17588
Special notes for your reviewer:
This is untested, need to verify that this solves the problem and that it doesn't cause problems on any other platforms.