Graphite: Do not change query when opening the query editor and there is no data #21588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellee
force-pushed
the
21563-graphite-select-metric
branch
from
2e41b8e
to
019ad5d
Compare
opening the Graphite query editor and there is no data for the last segment value. Fixes #21563
daniellee
force-pushed
the
21563-graphite-select-metric
branch
from
019ad5d
to
8280ede
Compare
daniellee
changed the title
marefr
changed the title
johntdyer
pushed a commit
to johntdyer/grafana
that referenced
this pull request
Jan 21, 2020
opening the Graphite query editor and there is no data for the last segment value. Fixes grafana#21563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the logic of the Graphite query editor so that it does not modify the metric path when a user opens the query editor. The old behavior was to execute a find query for the last part of the metric path and if there was no data, then it would change the value to be
select metric.The old behavior is still in place when toggling edit mode or for any other action that parses the metric path.
Fixes #21563