Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: PagerDuty: adding current state to the payload #29270

Merged
merged 6 commits into from
Mar 2, 2021
Merged

Alerting: PagerDuty: adding current state to the payload #29270

merged 6 commits into from
Mar 2, 2021

Conversation

eraac
Copy link
Contributor

@eraac eraac commented Nov 20, 2020 •
edited
Loading

What this PR does / why we need it:
The state of alert can be useful if you use event rule. Per example you can redirect to a specific service when the state is no_data or ignore it

Fixes #29812

@eraac eraac requested a review from a team as a code owner November 20, 2020 13:46
@eraac eraac requested review from aknuds1 and wbrowne and removed request for a team November 20, 2020 13:46
@aknuds1 aknuds1 added pr/external This PR is from external contributor pr/needs-discussion This PR needs a bigger discussion labels Nov 20, 2020
@stale
Copy link

stale bot commented Dec 4, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale Issue with no recent activity label Dec 4, 2020
@eraac
Copy link
Contributor Author

eraac commented Dec 5, 2020

Any news? It's really annoying for us to not be able to differentiate "no_data" and "alert" in PagerDuty

@stale stale bot removed the stale Issue with no recent activity label Dec 5, 2020
@aknuds1
Copy link
Contributor

aknuds1 commented Dec 5, 2020

Sorry, we have a lot on our hands currently, we are planning to get back to this.

@jessabe
Copy link
Contributor

jessabe commented Dec 14, 2020

Hej @eraac,

Thanks for the contribution. It would be great if you could create an issue to describe the use case & provide an example of how to use this for us to review this feature better.

Thanks!

@wbrowne wbrowne added needs more info Issue needs more information, like query results, dashboard or panel json, grafana version etc and removed pr/needs-discussion This PR needs a bigger discussion labels Dec 14, 2020
@eraac
Copy link
Contributor Author

eraac commented Dec 14, 2020

@jessabe job done #29812

@jessabe
Copy link
Contributor

jessabe commented Dec 14, 2020

@eraac thanks for this! Would you mind updating the relevant documentation for this and then we can get things merged. Cheers!

@eraac eraac requested a review from a team as a code owner December 14, 2020 14:13
@eraac eraac requested review from oddlittlebird and achatterjee-grafana and removed request for a team December 14, 2020 14:13
oddlittlebird
oddlittlebird reviewed Dec 14, 2020
View reviewed changes
docs/sources/alerting/notifications.md Outdated Show resolved Hide resolved
docs/sources/alerting/notifications.md Outdated Show resolved Hide resolved
@eraac @oddlittlebird
Apply suggestions from code review
2206327 
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
@stale
Copy link

stale bot commented Dec 28, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale Issue with no recent activity label Dec 28, 2020
@aknuds1 aknuds1 removed stale Issue with no recent activity needs more info Issue needs more information, like query results, dashboard or panel json, grafana version etc labels Dec 28, 2020
@aknuds1 aknuds1 added area/backend pr/needs-discussion This PR needs a bigger discussion type/feature-request and removed pr/needs-discussion This PR needs a bigger discussion labels Dec 28, 2020
@eraac
Copy link
Contributor Author

eraac commented Feb 22, 2021

Any update?

@aknuds1
Copy link
Contributor

aknuds1 commented Feb 22, 2021

Sorry for the long wait, we'll try to get around to it.

@aknuds1
Copy link
Contributor

aknuds1 commented Feb 24, 2021

Thanks, this looks pretty good so far, I will try to review it in depth soon.

@aknuds1
Copy link
Contributor

aknuds1 commented Mar 2, 2021

Sorry again for the long wait! Thanks for contributing to Grafana!

@aknuds1 aknuds1 merged commit bd0d051 into grafana:master Mar 2, 2021
@wbrowne wbrowne added this to the 7.5.0-beta1 milestone Mar 3, 2021
ryantxu pushed a commit to dejapong/grafana that referenced this pull request Mar 30, 2021
@eraac @oddlittlebird @ryantxu
Alerting: PagerDuty: adding current state to the payload (grafana#29270)
d49c58c 
* adding state to the payload

* fix test

* fix linter

* documentation payload current state

* Apply suggestions from code review

Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>

Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddlittlebird oddlittlebird oddlittlebird left review comments

@aknuds1 aknuds1 aknuds1 approved these changes

@wbrowne wbrowne Awaiting requested review from wbrowne

@achatterjee-grafana achatterjee-grafana Awaiting requested review from achatterjee-grafana

Assignees
No one assigned
Labels
add to changelog area/backend pr/external This PR is from external contributor type/feature-request
Projects
None yet
Milestone
7.5.0-beta1
Development

Successfully merging this pull request may close these issues.

Alerting: PagerDuty: add current state into the payload
5 participants
@eraac @aknuds1 @jessabe @oddlittlebird @wbrowne