CloudMonitoring: Prevent resource type variable function from crashing #30901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papagian
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
I think it works fine: if I select Resource Type as a query type no more crashes (but I don't get any result). If I use another cloud monitoring datasource, it still does not crashes but I get a permission denied error (I guess because I lack permission to perform such query).
sunker
force-pushed
the
fix/30491-resource-type
branch
from
b7aefca
to
696b166
Compare
joshhunt
approved these changes
Feb 8, 2021
| return labels['resource.type'].map(this.toFindQueryResult); | ||
| return labels.hasOwnProperty('resource.type') ? labels['resource.type'].map(this.toFindQueryResult) : []; |
There was a problem hiding this comment.
you could probably write this as labels['resource.type']?.map() ?? [] if you so cared
There was a problem hiding this comment.
oh I didn't mean to actually submit this comment 😅
There was a problem hiding this comment.
yes yes much better, thanks!
ryantxu
pushed a commit
that referenced
this pull request
Feb 24, 2021
#30901) * check if label response has resource type prop * use nullish coalescing operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30491