Cloudwatch: Add AWS/DDoSProtection metrics and dimensions #31297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
relvira
changed the title
sunker
approved these changes
Feb 18, 2021
|
thanks for jumping in @sunker! I was waiting for confirmation from my employer to sign the CLA, to which I've been given green light and is now signed 🙌🏼. The Go tests were cancelled for this PR, not sure what happened there. Let me know if there's anything else I can do to move this forward. Happy to contribute! |
|
hey @sunker, just touching base on this PR again. As it's approved and CLA has been signed, anything else pending for it to be merged? Thanks! |
|
thanks @relvira! |
sunker
changed the title
ryantxu
pushed a commit
that referenced
this pull request
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
AWS Shield recently announced new metrics available on Cloudwatch (see blog post).
This PR adds those to
tsdb/cloudwatch/metric_find_query.goso that they can be discovered via Grafana.Which issue(s) this PR fixes:
Fixes #31273
Special notes for your reviewer:
These metrics and dimensions have not yet been added to AWS Shield metrics documentation, AWS Shield engineers have send me a list of these so we can get them added to Grafana. I can provide output from the CloudWatch API proving these exist if needed.