Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-distributed] Add metrics max duration config #3321

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

bvillanueva-mdsol
Copy link
Contributor

Background:
We wanted to expand current metrics generator's config metrics.max_duration from default 3h to something bigger.

Goal:
Allow update on metrics generator's config metrics.max_duration configuration.

Doc: metrics.max_duration is found in this documentation: https://grafana.com/docs/tempo/latest/configuration/#query-frontend

Signed-off-by: Brent Villanueva <bvillanueva@mdsol.com>
Signed-off-by: Brent Villanueva <bvillanueva@mdsol.com>
@abenbachir
Copy link
Contributor

abenbachir commented Oct 1, 2024

When this max_duration config can be merged ?

@bvillanueva-mdsol
Copy link
Contributor Author

Thanks for the ping @abenbachir. The PR was not updated to latest main. Just updated now. We can now able to merge 🙇

@abenbachir
Copy link
Contributor

@Sheikh-Abubaker this PR needs to be reviewed.

@bvillanueva-mdsol
Copy link
Contributor Author

Looks like as a workaround I saw this post in community slack channel: https://grafana.slack.com/archives/C01D981PEE5/p1728294653138369?thread_ts=1728293373.828449&cid=C01D981PEE5

        tempo:
          structuredConfig:
            query_frontend:
              metrics:
                max_duration: 12h      

it works on my local too.

@abenbachir , looks like we dont need this PR anymore. What do you think?

@abenbachir
Copy link
Contributor

Looks like as a workaround I saw this post in community slack channel: https://grafana.slack.com/archives/C01D981PEE5/p1728294653138369?thread_ts=1728293373.828449&cid=C01D981PEE5

        tempo:
          structuredConfig:
            query_frontend:
              metrics:
                max_duration: 12h      

it works on my local too.

@abenbachir , looks like we dont need this PR anymore. What do you think?

yeah i saw that thread as well.

@Sheikh-Abubaker
Copy link
Collaborator

Sheikh-Abubaker commented Oct 13, 2024

@bvillanueva-mdsol could you please bump the chart version to 1.19.0 ? Thanks!

Sheikh-Abubaker and others added 3 commits October 22, 2024 03:22
Signed-off-by: Brent Villanueva <bvillanueva@mdsol.com>
Signed-off-by: Brent Villanueva <bvillanueva@mdsol.com>
@bvillanueva-mdsol
Copy link
Contributor Author

@Sheikh-Abubaker sorry for the late reply. Got it bumped to 1.20.0 on latest updates

@Sheikh-Abubaker
Copy link
Collaborator

@Sheikh-Abubaker sorry for the late reply. Got it bumped to 1.20.0 on latest updates

@bvillanueva-mdsol no worries!

Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sheikh-Abubaker Sheikh-Abubaker requested review from mapno and removed request for mapno October 21, 2024 22:27
@Sheikh-Abubaker
Copy link
Collaborator

Sheikh-Abubaker commented Oct 21, 2024

@mapno could you please review this.

@mapno mapno merged commit 07419bd into grafana:main Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants