[promtail] Introduce .Release.Namespace in objects meta #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariusz Waligóra <mariusz@piwik.pro>
torstenwalter
previously approved these changes
Jul 27, 2021
|
@marucha please look at the failed ci jobs:
|
…ontext. Signed-off-by: Mariusz Waligóra <mariusz@piwik.pro>
torstenwalter
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds .Release.Namespace to objects meta for promtail chart. Related to discussion in this issue.
Benefits
Ability to use the helm chart when having declarative definition of all cluster objects rendered using helm template.
Possible drawbacks
I don't see any, it will work as previously for helm install
Signed-off-by: Mariusz Waligóra mariusz@piwik.pro