-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add library for replaying Chrome DevTools recordings #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review
@@ -7,6 +7,11 @@ | |||
"versions": ["0.0.1", "0.0.2", "0.0.3", "0.0.4", "0.1.0"], | |||
"docs-url": "https://github.com/grafana/k6-jslib-summary" | |||
}, | |||
"k6-replay": { | |||
"versions": ["1.0.0"], | |||
"docs-url": "https://grafana.com/docs/k6/latest/using-k6-browser#todo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There won't be docs until the extension has been released and if we keep the lib hidden, then we might not need them at all.
"k6-replay": { | ||
"versions": ["1.0.0"], | ||
"docs-url": "https://grafana.com/docs/k6/latest/using-k6-browser#todo", | ||
"published": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this to keep the lib hidden from the homepage, but available on the "CDN".
Tests seem to fail randomly in the crocFlow suite. Nothing in this PR could have caused that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😗 👌🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
We're releasing a new Chrome extension that allows the DevTools Recorder to export a k6 Browser script. This PR adds a module containing the runner needed for the generated scripts.
NOTE: I added a
published
property to the page generator because because we don't want users to become dependent on this library unless they've used the browser extension. I also expect to be continuously updating v1.0.0 of the library while I'm testing the extension e2e, so it's a good idea to keep it hidden at least until the extension is released.Please fill in this template.
npm run test
command succeeds.yarn run generate-homepage
locally and verify the new homepage/lib/index.html
file looks legit.Select one of these and delete the others:
If adding a new jslib:
/lib/{jslib_name}
folder./lib/{jslib_name}/{desired_version}
folder./lib/{jslib_name}/{desired_version}/index.js
file containing the jslib's code bundle exists.supported.json
file to contain an entry for the newly added jslib and its{desired_version}
, as in the following example:/tests/basic.js
and/tests/testSuite.js
to ensure that the added jslib is importable and runnable by k6. (Did not do because the runner code exports test options that are expected to be re-exported by the test script itself, and I can't re-export it easily in the test runner script).