Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker mixin: Adds root cgroup filter to filter out root cgroup stats #1316

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Docker mixin: Adds root cgroup filter to filter out root cgroup stats #1316

merged 5 commits into from
Aug 26, 2024

Conversation

mshahzeb
Copy link
Contributor

Adds a root cgroup filter - otherwise metrics get inflated when metrics are counted which do not have a name label.

@mshahzeb mshahzeb requested a review from a team as a code owner August 22, 2024 22:20
v-zhuravlev
v-zhuravlev approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@v-zhuravlev v-zhuravlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks.
I think you can also use:
id=~"/system.slice/docker.+" to make sure metrics are related to docker, not cgroups?

hairyhenderson
hairyhenderson approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@hairyhenderson hairyhenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mshahzeb mshahzeb merged commit 952e46f into master Aug 26, 2024
3 checks passed
@mshahzeb mshahzeb deleted the shahzeb/docker-add-root-cgroup-filter branch August 26, 2024 15:51
@mshahzeb mshahzeb mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-zhuravlev v-zhuravlev v-zhuravlev approved these changes

@hairyhenderson hairyhenderson hairyhenderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshahzeb @hairyhenderson @v-zhuravlev