Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add current all to clickhouse-mixin #1354

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Add current all to clickhouse-mixin #1354

merged 2 commits into from
Nov 12, 2024

Conversation

v-zhuravlev
Copy link
Contributor

This to ensure all nodes(instances) of clickhouse cluster are selected when nothing is set specifically.
Updated via old grafonnet funcion arg.

@v-zhuravlev v-zhuravlev requested a review from a team as a code owner November 12, 2024 08:30
Dasomeone
Dasomeone approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Vitaly

@v-zhuravlev v-zhuravlev merged commit 69196e8 into master Nov 12, 2024
5 checks passed
@v-zhuravlev v-zhuravlev deleted the clickhouse- branch November 12, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dasomeone Dasomeone Dasomeone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-zhuravlev @Dasomeone