Update ceph overview dashboard stat panels to support Light Mode #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates the schema for the dashboard to schemaversion 40, with some plugin syntax updates
|
For context here, the dashboard now looks like this in both light and dark mode As compared to previously |
|
Hi, could someone review it, please? |
|
Thanks @AleksandraGrafana, made me realised I'd merged out of order. The hotfix is still live, however, so nothing immediate to worry about. Have poked folks for a review :) |
v-zhuravlev
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ceph mixin stat panels to support Light theme, specifically as they had hardcoded bright text.
Also updates the schema for the dashboard to schemaversion 40, with some plugin syntax updates