Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comma handling in PromQL/LoqQL queries for commonlib/logs-lib #1372

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

v-zhuravlev
Copy link
Contributor

This adds comma handling in PromQL/LoqQL queries for commonlib/logs-lib expressions. Dependency to #1370 .

@v-zhuravlev v-zhuravlev requested a review from a team as a code owner December 11, 2024 09:55
@v-zhuravlev v-zhuravlev changed the title Vzhuravlev/filtering selector empty comma handling in PromQL/LoqQL queries for commonlib/logs-lib Dec 11, 2024
common-lib/common/variables/variables.libsonnet Outdated Show resolved Hide resolved
logs-lib/logs/variables.libsonnet Outdated Show resolved Hide resolved
Co-authored-by: Emily <1282515+Dasomeone@users.noreply.github.com>
@v-zhuravlev v-zhuravlev merged commit 9162ba8 into master Dec 11, 2024
4 checks passed
@v-zhuravlev v-zhuravlev deleted the vzhuravlev/filteringSelectorEmpty branch December 11, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants