Update Request and Response to return Promise #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allansson
requested review from
mstoykov,
codebien,
oleiade,
olegbespalov,
nicolevanderhoeven,
ankur22,
inancgumus,
ka3de and
joanlopez
as code owners
allansson
removed request for
mstoykov,
oleiade,
ankur22,
codebien,
olegbespalov,
joanlopez,
ka3de and
nicolevanderhoeven
allansson
commented
Jun 18, 2024
| @@ -1203,105 +1203,105 @@ async function test() { | |||
| // | |||
| // Request | |||
| // | |||
| const request = page.goto(url).then(r => r?.request()); | |||
There was a problem hiding this comment.
Added ! to the returned request to make sure we're testing the right thing. Without it, we need to use ?. everywhere, changing the return type. This is a problem in case we want to do a change where a function actually returns undefined. Then we get a positive on the test for the wrong reason.
|
|
||
| // $ExpectType Promise<Record<string, string> | undefined> | ||
| request.then(r => r?.allHeaders()); |
There was a problem hiding this comment.
This pattern is what had me believe that the APIs were already async. I updated it to improve readability and to avoid errors where returning a Promise inside another Promise would flatten into a Promise.
Comment on lines
+1300
to
+1301
| // $ExpectType Promise<{ body: number; headers: number; }> | ||
| response.size(); |
There was a problem hiding this comment.
This function did not have a counter-part in Playwright, but I assumed that it's signature would be the same as the one in Request.
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpm test <package to test>.- Migrate Response APIs to async xk6-browser#1309
- Migrate Request APIs to async xk6-browser#1308