Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document gracefulStop doesn't work for the externally-controlled executor #989

Closed
na-- opened this issue Jan 19, 2023 · 0 comments · Fixed by #994
Closed

Document gracefulStop doesn't work for the externally-controlled executor #989

na-- opened this issue Jan 19, 2023 · 0 comments · Fixed by #994
Assignees
@MattDodsonEnglish
Labels
Area: OSS Content Improvements or additions to community/oss documentation Priority: High Type: Bug Something doesn't work how it should

Comments

@na--
Copy link
Member

na-- commented Jan 19, 2023

Prompted by grafana/k6#2859, we should document that the gracefulStop is not quite universal, since it isn't supported by the externally-controlled executor.
@na-- na-- added Area: OSS Content Improvements or additions to community/oss documentation Priority: High Type: Bug Something doesn't work how it should labels Jan 19, 2023
@na-- na-- mentioned this issue Jan 19, 2023
Open
@MattDodsonEnglish MattDodsonEnglish self-assigned this Jan 20, 2023
MattDodsonEnglish added a commit that referenced this issue Jan 20, 2023
@MattDodsonEnglish
note externally controlled's lack of graceful stop
bb03a25 
Fixes #989
@MattDodsonEnglish MattDodsonEnglish mentioned this issue Jan 20, 2023
Merged
MattDodsonEnglish added a commit that referenced this issue Jan 20, 2023
@MattDodsonEnglish
note externally controlled's lack of graceful stop
744ebae 
Fixes #989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattDodsonEnglish MattDodsonEnglish

Labels
Area: OSS Content Improvements or additions to community/oss documentation Priority: High Type: Bug Something doesn't work how it should
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

note externally controlled's lack of graceful stop grafana/k6-docs
2 participants
@na-- @MattDodsonEnglish