-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Executors, explain vu cycling in arrival-rate #1016
Conversation
...n/translated-guides/en/02 Using k6/14 Scenarios/00 Concepts/02 Arrival-rate VU allocation.md
Outdated
Show resolved
Hide resolved
...n/translated-guides/en/02 Using k6/14 Scenarios/00 Concepts/02 Arrival-rate VU allocation.md
Outdated
Show resolved
Hide resolved
There's a version of the docs published here: https://mdr-ci.staging.k6.io/docs/refs/pull/1016/merge It will be deleted automatically in 30 days. |
then the value of `{exec.vu.iterationInScenario}` will reach `15` at some points, | ||
even if k6 never requires that number of VUs to reach the target iteration. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then the value of `{exec.vu.iterationInScenario}` will reach `15` at some points, | |
even if k6 never requires that number of VUs to reach the target iteration. | |
then the value of `{exec.vu.iterationInScenario}` will reach `15` at some points, | |
even if k6 never requires that number of VUs to reach the target iteration *at the same time*. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise I can read this as even if I only had to to 10 iterations (1iter/s for 10s) but got 15 VUs I will still use all 15 VUs ... somehow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I'm a little lost at both yours and mine.
Maybe:
even if the executor never requires all 15 VUs to reach the target rate.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean it is better as rate is the key word. My problem is that somebody who doesn't understand this all that well likely will be just as confused.
IMO it is better to be more explicit in what is that we are trying to say when it is confusing to begin with.
In this case for me the key parts are:
- k6 will use at most as many VUs at a time to hit the provided rate
- this VUs will not necessarily be the first N VUs only even if only N or less VU are needed at any given moment.
I am not certain guaranteeing that it will go through all the VUs is a good idea - this is an implementation detail that likely is never necessary to be known.
If it's still confusing with that sentence, I think it might be easier to communicate visually.
|
7c3754c
to
79c10d6
Compare
Thanks, I think it's much more general and useful with: 79c10d6 I added the part about shared array because I want to avoid any chance of confusion if someone misunderstands the admonition. I still kept in a little miniature section in the allocation explanation since a little redundancy can be effective. |
src/data/markdown/translated-guides/en/02 Using k6/14 Scenarios/01 Executors.md
Outdated
Show resolved
Hide resolved
…s/01 Executors.md Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>
Closes #136