-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename web vital metrics in docs #1178
Merged
ankur22
merged 5 commits into
update/browser-cloud-updates
from
rename/884-rename-web-vital-metrics
Jun 12, 2023
Merged
Rename web vital metrics in docs #1178
ankur22
merged 5 commits into
update/browser-cloud-updates
from
rename/884-rename-web-vital-metrics
Jun 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a version of the docs published here: https://mdr-ci.staging.k6.io/docs/refs/pull/1178/merge It will be deleted automatically in 30 days. |
mdcruz
approved these changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Please merge this PR to #1208 if it's not for v0.10.0 🙇 |
ankur22
force-pushed
the
rename/884-rename-web-vital-metrics
branch
from
June 12, 2023 12:14
fca54e1
to
51909cf
Compare
Renames from webvital_first_input_delay to browser_web_vital_fid.
Rename from webvital_time_to_first_byte to browser_web_vital_ttfb.
Rename from webvital_cumulative_layout_shift to browser_web_vital_cls.
Rename from webvital_first_contentful_paint to browser_web_vital_fcp
ankur22
force-pushed
the
rename/884-rename-web-vital-metrics
branch
from
June 12, 2023 12:20
51909cf
to
5c4eb7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser module has renamed the web vital metrics that it emits. You can find more details on why the change was made here: grafana/xk6-browser#884.
This rename change also needs to be reflected in the docs.