Update to Async Page
#1602
Merged
Update to Async Page
#1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
async/browser-page
branch
from
9992631
to
99593e2
Compare
ankur22
approved these changes
May 31, 2024
docs/sources/next/javascript-api/k6-experimental/browser/page/dollar.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/page/doubledollar.md
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/page/innertext.md
Outdated
Show resolved
Hide resolved
allansson
reviewed
Jun 3, 2024
There was a problem hiding this comment.
A lot of changes here and I've tried to go through them all. I think we have to accept that we're not going to be able to catch every little mistake in the docs, especially when it comes to the more frequently used API:s.
I found some examples which I think weren't up to date and I listed the files in a separate message.
Overall, looks good! 👍
docs/sources/next/javascript-api/k6-experimental/browser/page/dollar.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/page/dollar.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/page/opener.md
Outdated
Show resolved
Hide resolved
allansson
approved these changes
Jun 3, 2024
5 tasks
inancgumus
added a commit
that referenced
this pull request
Jun 7, 2024
inancgumus
added a commit
that referenced
this pull request
Jun 10, 2024
inancgumus
added a commit
that referenced
this pull request
Jun 11, 2024
inancgumus
added a commit
that referenced
this pull request
Jun 18, 2024
inancgumus
added a commit
that referenced
this pull request
Jun 19, 2024
inancgumus
added a commit
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update relevant
Pagemethods from sync to async.Checklist
npm startcommand locally and verified that the changes look good.docs/sources/nextfolder of the documentation.docs/sources/v{most_recent_release}folder of the documentation.Related PR(s)/Issue(s)
grafana/xk6-browser#1307