Utils for tagging stages #6
Conversation
src/stages.js
Outdated
| // TODO: should we use another tag key? | ||
| exec.vu.tags['stage'] = getStageProfile() |
There was a problem hiding this comment.
My opinion is that at least tagWithCurrentStageIndex and tagWithCurrentStageProfile should not use the same key. I mean, what if a customer wants to have them both? 🤔
src/stages.js
Outdated
| // TODO: should we use another tag key? | ||
| exec.vu.tags['stage'] = getStageProfile() |
There was a problem hiding this comment.
My opinion is that at least tagWithCurrentStageIndex and tagWithCurrentStageProfile should not use the same key. I mean, what if a customer wants to have them both? 🤔
|
Added some more edge cases, and applied more refactor for making the code a bit more readable. Let me know if you have better ideas for having a better code for |
|
Ok, based on the approvals we are ready to open a PR on the docs and the relative PR on |
|
Cool to see "unit tests" using k6chaijs! 🎉 |
This PR implements the code for tagging stages, adding some utils function for getting and tagging with the index (or the computed profile) of the current running stage.
It requires an
xk6build of grafana/k6#2493 for running the tests.