Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove httpbin.org from tests #1207

Closed
cuonglm opened this issue Oct 18, 2019 · 1 comment
Closed

Remove httpbin.org from tests #1207

cuonglm opened this issue Oct 18, 2019 · 1 comment
Assignees
Labels

Comments

@cuonglm
Copy link
Contributor

cuonglm commented Oct 18, 2019

Current tests still use httpbin.org, make the test flaky sometimes.

> for _ in {1..10}; do go1.12.12 test -race -run=TestResponseTimingsWhenTimeout; done
WARN[0007] Request Failed                                error="Get http://httpbin.org/delay/10: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
PASS
ok      github.com/loadimpact/k6/js/modules/k6/http    8.901s
WARN[0007] Request Failed                                error="Get http://httpbin.org/delay/10: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
PASS
ok      github.com/loadimpact/k6/js/modules/k6/http    8.840s
WARN[0007] Request Failed                                error="Get http://httpbin.org/delay/10: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
PASS
ok      github.com/loadimpact/k6/js/modules/k6/http    8.530s
WARN[0007] Request Failed                                error="Get http://httpbin.org/delay/10: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
PASS
ok      github.com/loadimpact/k6/js/modules/k6/http    8.621s
WARN[0007] Request Failed                                error="Get http://httpbin.org/delay/10: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
PASS
ok      github.com/loadimpact/k6/js/modules/k6/http    8.874s
WARN[0007] Request Failed                                error="Get http://httpbin.org/delay/10: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
PASS
ok      github.com/loadimpact/k6/js/modules/k6/http    8.605s
WARN[0007] Request Failed                                error="Get http://httpbin.org/delay/10: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
--- FAIL: TestResponseTimingsWhenTimeout (7.18s)
        Error Trace:    request_test.go:1776
        Error:          Received unexpected error:
                        Error: expected waiting time to be over 2000ms but was 1068.554 at <eval>:5:8(25)
        Test:           TestResponseTimingsWhenTimeout
FAIL
exit status 1
FAIL    github.com/loadimpact/k6/js/modules/k6/http    7.510s
WARN[0007] Request Failed                                error="Get http://httpbin.org/delay/10: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
PASS
ok      github.com/loadimpact/k6/js/modules/k6/http    8.947s
WARN[0007] Request Failed                                error="Get http://httpbin.org/delay/10: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
PASS
ok      github.com/loadimpact/k6/js/modules/k6/http    8.613s
WARN[0007] Request Failed                                error="Get http://httpbin.org/delay/10: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
PASS
ok      github.com/loadimpact/k6/js/modules/k6/http    8.641s
@cuonglm cuonglm added the tests label Oct 18, 2019
@cuonglm cuonglm added this to the v0.27.0 milestone Oct 18, 2019
@cuonglm cuonglm self-assigned this Oct 18, 2019
@na--
Copy link
Member

na-- commented Oct 18, 2019

Oops 😅 Sorry, I was the one who removed the test dependencies on the external httpbin.org in #555, but it seems I slipped up and inadvertently added a new one in #1047 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants