Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the execution mismatch check, but keep the other warnings #1076

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Disable the execution mismatch check, but keep the other warnings #1076

merged 1 commit into from
Jul 9, 2019

Conversation

na--
Copy link
Member

@na-- na-- commented Jul 9, 2019

Full description of the issue and rationale for the change can be found here: #1007 (comment)

@na--
Disable the execution mismatch check, but keep the warnings
9a4c075 
Full description of the issue and rationale for the change can be found here: #1007 (comment)
@na-- na-- requested a review from mstoykov July 9, 2019 12:48
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #1076 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
- Coverage   72.79%   72.79%   -0.01%     
==========================================
  Files         133      133              
  Lines        9905     9890      -15     
==========================================
- Hits         7210     7199      -11     
+ Misses       2278     2276       -2     
+ Partials      417      415       -2
Impacted Files Coverage Δ
cmd/config.go 76.02% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd417e...9a4c075. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 9, 2019 •
edited
Loading

Codecov Report

Merging #1076 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
- Coverage   72.79%   72.79%   -0.01%     
==========================================
  Files         133      133              
  Lines        9905     9890      -15     
==========================================
- Hits         7210     7199      -11     
+ Misses       2278     2276       -2     
+ Partials      417      415       -2
Impacted Files Coverage Δ
cmd/config.go 76.02% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd417e...9a4c075. Read the comment docs.

mstoykov
mstoykov approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just trying to confirm that the warning that is now missing is the one I am seeing as it took me 5 minutes ...

cmd/config.go Show resolved Hide resolved
@na-- na-- merged commit 5af8e03 into master Jul 9, 2019
@na-- na-- deleted the fix-execution-derivation-redux branch July 9, 2019 13:25
@na-- na-- mentioned this pull request Jul 12, 2019
Merged
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoykov mstoykov mstoykov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@na-- @mstoykov