Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make JSON output logging less noisy #1470

Merged
merged 1 commit into from
Jun 9, 2020
Merged

make JSON output logging less noisy #1470

merged 1 commit into from
Jun 9, 2020

Conversation

michiboo
Copy link
Contributor

Address issues #1469
Increase time interval between log message to 200 milliseconds
Remove Writing JSON metrics message
Add if statement output log based on no of count

@CLAassistant
Copy link

CLAassistant commented May 28, 2020

CLA assistant check
All committers have signed the CLA.

@na--
Copy link
Member

na-- commented Jun 2, 2020

Thanks for making this PR! Not sure if you've seen the lint error, but please move the 200ms to a constant so that is stops complaining 😅

Increase time interval between log message to 200 milliseconds
Remove Writing JSON metrics message
Add if statement output log based on no of count
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! I have no idea why the linter fails, it's supposed to ignore old linter issues that PRs haven't touched 😕

@na-- na-- changed the base branch from master to new-schedulers June 9, 2020 10:53
@imiric
Copy link
Contributor

imiric commented Jun 9, 2020

The linter is probably getting confused since this branch seems to have been based on an old master commit, and the PR is to new-schedulers.

@michiboo Can you rebase your reduce_verbose branch on the current new-schedulers (d932446)? EDIT: Nevermind, it was mergable as is, and the linter should pass on the new-schedulers build. Thanks for your contribution!

@imiric imiric merged commit 0839be8 into grafana:new-schedulers Jun 9, 2020
@mstoykov mstoykov added this to the v0.27.0 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants