Override with env variables the cloud config

[mstoykov]

This is how it should've been but ... because of the way this is
configurable ... it is somewhat complicated ...

The alternative to this (at this point) is to have the output know how
to merge the env variables back ... which seems even worse

[codecov-commenter]

Codecov Report

Merging #1583 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1583      +/-   ##
==========================================
- Coverage   77.13%   77.09%   -0.04%     
==========================================
  Files         162      162              
  Lines       13263    13270       +7     
==========================================
+ Hits        10230    10231       +1     
- Misses       2512     2518       +6     
  Partials      521      521              

Impacted Files	Coverage Δ
cmd/cloud.go	7.74% <0.00%> (-0.37%)	⬇️
cmd/collectors.go	0.00% <0.00%> (ø)
lib/netext/httpext/request.go	96.73% <0.00%> (-0.55%)	⬇️
lib/testutils/minirunner/minirunner.go	82.14% <0.00%> (+3.57%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b83dbbd...b3b8aaa. Read the comment docs.

[imiric]

@mstoykov Could you rebase this on master?

[mstoykov]

This will have to wait for #1599 as it likely will have conflicts either way

[codecov-io]

Codecov Report

Merging #1583 into master will increase coverage by 0.12%.
The diff coverage is 64.68%.

@@            Coverage Diff             @@
##           master    #1583      +/-   ##
==========================================
+ Coverage   72.10%   72.22%   +0.12%     
==========================================
  Files         167      175       +8     
  Lines       12882    13449     +567     
==========================================
+ Hits         9288     9714     +426     
- Misses       3031     3127      +96     
- Partials      563      608      +45     

Flag	Coverage Δ
#ubuntu	72.20% <64.68%> (+0.11%)	⬆️
#windows	70.76% <64.68%> (+0.20%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/cloud.go	6.55% <0.00%> (-0.23%)	⬇️
cmd/collectors.go	0.00% <0.00%> (ø)
js/bundle.go	90.20% <ø> (ø)
lib/testutils/httpmultibin/httpmultibin.go	89.88% <ø> (-2.52%)	⬇️
lib/types/dns_policy_gen.go	36.36% <36.36%> (ø)
lib/types/dns_select_gen.go	45.45% <45.45%> (ø)
lib/netext/dialer.go	93.75% <50.00%> (-2.17%)	⬇️
lib/types/dns.go	68.29% <68.29%> (ø)
cmd/options.go	61.96% <70.00%> (+0.52%)	⬆️
js/runner.go	82.15% <75.75%> (-0.18%)	⬇️
... and 19 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e39d45...48c64ef. Read the comment docs.

[mstoykov]

Given how fragile this code has been in the past and that with #1155 we will write completely new version of this handling I am closing this is issue in favor it just getting fixed then.

This basically fixed if you have configured a cloud option through the script, to be able to overwrite it from outside the script. Which is likely is a very rare use case