-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preload grafana dashboard with docker-compose setup #1610
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1610 +/- ##
=======================================
Coverage 74.82% 74.82%
=======================================
Files 164 164
Lines 14035 14035
=======================================
Hits 10501 10501
Misses 3002 3002
Partials 532 532
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I have some reservations about us putting, even more, grafana specific things in the k6 repo ... because even now people ask us questions that are grafana/influxdb related. And to be perfectly honest I don't think we should be the one trying to answer them, and usually, it requires that we go read the grafana/influxdb documentation to figure it out, which arguably should be what, the person who asked the question, have done in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I share your concern @mstoykov, but suggest we merge this for now and continue the discussions about whether to split this out to another repo in a separate forum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't actually tried the new default dashboard, but considering we're soon going to move the docker-compose files to a separate example repo (#1614), LGTM 😅
Thank you so much for your contribution, @jeevananthank! 🙏🏼 |
Today's setup of docker-compose does not preload the dashboard when running the tests locally. This PR solves the issues and detailed description is in the link below.
The grafana dashboard used here is more generic and simple and one can update as per their needs.
https://community.k6.io/t/preload-grafana-dashbaord-with-docker-compose-setup/874