-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #2159
Update dependencies #2159
Conversation
There are some updates, nothing relevant to our usecase
Some probably irrelevant to us compatibility fixes with protoc
Mostly optimizations in a dependancy that trickles up
Optimizations and dropping github.com/golang/snappy as dependency and instead use faster (and smaller) internal implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a minor nitpick. It's nice to see that golang.org/x/crypto/ssh/terminal has finally been replaced with golang.org/x/term:
k6/vendor/golang.org/x/crypto/ssh/terminal/terminal.go
Lines 8 to 23 in 5c25ef3
// Deprecated: this package moved to golang.org/x/term. | |
package terminal | |
import ( | |
"io" | |
"golang.org/x/term" | |
) | |
// EscapeCodes contains escape sequences that can be written to the terminal in | |
// order to achieve different styles of text. | |
type EscapeCodes = term.EscapeCodes | |
// Terminal contains the state for running a VT100 terminal that is capable of | |
// reading lines of input. | |
type Terminal = term.Terminal |
We should probably replace our own usage of the original package and drop the module entirely with this update, it seems fairly straightforward to do: https://github.com/grafana/k6/search?q=golang.org%2Fx%2Fcrypto%2Fssh%2Fterminal
@mstoykov regarding this:
what functionality is it? |
|
This became a lot bigger than anticipated ... Especially the
x/
updates are quite big 🤞There is slight update on all, but in most cases it is "nothing interesting to us" or "small optimizations here and there" except the
x/*
ones where I skipped that as the changelog is quite big and only in commit messages ;(Skipped upgrades:
k6/html
so decided to skip it for now, maybe an issue needs to be openedk6/crypto/x509
code that is being looked after in ExportTo throws error fromstring
to[]byte
dop251/goja#333