Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #2159

Merged
merged 9 commits into from
Oct 5, 2021
Merged

Update dependencies #2159

merged 9 commits into from
Oct 5, 2021

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Oct 5, 2021

This became a lot bigger than anticipated ... Especially the x/ updates are quite big 🤞
There is slight update on all, but in most cases it is "nothing interesting to us" or "small optimizations here and there" except the x/* ones where I skipped that as the changelog is quite big and only in commit messages ;(

Skipped upgrades:

  • cobra - there is nothing we care about IMO it updates proto/grpc libraries 🤦
  • color/istty and co. - there are some changes between the repositories and it seems there will be more releases soon - next few days
  • goquery - adds new functionality that we will need to update k6/html so decided to skip it for now, maybe an issue needs to be opened
  • goja - there is an issue with some of our current k6/crypto/x509 code that is being looked after in ExportTo throws error from string to []byte dop251/goja#333

There are some updates, nothing relevant to our usecase
Some probably irrelevant to us compatibility fixes with protoc
Mostly optimizations in a dependancy that trickles up
Optimizations and dropping github.com/golang/snappy as dependency and
instead use faster (and smaller) internal implementation
@mstoykov mstoykov added this to the v0.35.0 milestone Oct 5, 2021
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor nitpick. It's nice to see that golang.org/x/crypto/ssh/terminal has finally been replaced with golang.org/x/term:

// Deprecated: this package moved to golang.org/x/term.
package terminal
import (
"io"
"golang.org/x/term"
)
// EscapeCodes contains escape sequences that can be written to the terminal in
// order to achieve different styles of text.
type EscapeCodes = term.EscapeCodes
// Terminal contains the state for running a VT100 terminal that is capable of
// reading lines of input.
type Terminal = term.Terminal

We should probably replace our own usage of the original package and drop the module entirely with this update, it seems fairly straightforward to do: https://github.com/grafana/k6/search?q=golang.org%2Fx%2Fcrypto%2Fssh%2Fterminal

yorugac
yorugac previously approved these changes Oct 5, 2021
@yorugac
Copy link
Contributor

yorugac commented Oct 5, 2021

@mstoykov regarding this:

goquery - adds new functionality that we will need to update k6/html so decided to skip it for now, maybe an issue needs to be opened

what functionality is it?

@mstoykov
Copy link
Contributor Author

mstoykov commented Oct 5, 2021

@yorugac

2021-06-14 (v1.7.0) : Add Single and SingleMatcher functions to optimize first-match selection (thanks @gdollardollar).

@mstoykov mstoykov requested a review from yorugac October 5, 2021 13:09
@mstoykov mstoykov merged commit 32f80d1 into master Oct 5, 2021
@mstoykov mstoykov deleted the updateDependencies branch October 5, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants