Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Github forms #2174

Merged
merged 15 commits into from
Oct 12, 2021
Merged

New Github forms #2174

merged 15 commits into from
Oct 12, 2021

Conversation

divshacker
Copy link
Contributor

fixes #2171

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2021

CLA assistant check
All committers have signed the CLA.

@divshacker
Copy link
Contributor Author

@na--
Made one for reporting bug.
There are few things that I need to discuss.

  1. I don't have idea about what version to fill drop down fields. Can you please look in into it and let me know your suggestions.
  2. I have made a bug.yaml file. Please check that and let me know if any addition alteration needed or not.
    Thanks

@divshacker
Copy link
Contributor Author

divshacker commented Oct 11, 2021

Added feature_request.yaml
I think this should not have any problems.

Also I haven't found anything in PR template. Let me know your views.

@divshacker
Copy link
Contributor Author

@na-- Please review this PR.
Thanks

@divshacker
Copy link
Contributor Author

@yorugac I have updated that. Let me know any further suggestions.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #2174 (cc41068) into master (42f2e60) will increase coverage by 0.01%.
The diff coverage is 68.42%.

❗ Current head cc41068 differs from pull request most recent head b0016c4. Consider uploading reports for the commit b0016c4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2174      +/-   ##
==========================================
+ Coverage   72.71%   72.73%   +0.01%     
==========================================
  Files         184      184              
  Lines       14571    14577       +6     
==========================================
+ Hits        10596    10602       +6     
  Misses       3333     3333              
  Partials      642      642              
Flag Coverage Δ
ubuntu 72.67% <68.42%> (+0.02%) ⬆️
windows 72.37% <68.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/login_cloud.go 0.00% <0.00%> (ø)
cmd/login_influxdb.go 0.00% <0.00%> (ø)
cmd/ui.go 20.61% <0.00%> (ø)
lib/metrics/metrics.go 100.00% <ø> (ø)
ui/form_fields.go 45.71% <0.00%> (ø)
output/csv/config.go 74.00% <100.00%> (+4.23%) ⬆️
output/csv/output.go 67.30% <100.00%> (ø)
lib/execution_segment.go 92.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd316f0...b0016c4. Read the comment docs.

@divshacker
Copy link
Contributor Author

divshacker commented Oct 12, 2021

totally agree, it should be just some optional for provide more details. I would also delete the part , if applicable:

Done!

Copy link
Contributor

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!

@divshacker
Copy link
Contributor Author

Thanks! for approving

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@na-- na-- merged commit c826104 into grafana:master Oct 12, 2021
@na-- na-- added this to the v0.35.0 milestone Oct 12, 2021
Comment on lines +17 to +23
- type: dropdown
attributes:
label: OS
options:
- Windows
- Linux
- Mac
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry I'm late... Do we want to add an OS version input field? It might not be relevant in most cases, but it's good to know if someone's running on e.g. Windows XP 😄

Also maybe s/Mac/macOS/?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm fair enough 😅 this should also probably be a separate free text field with examples (e.g. "Windows 10, Arch Linux, macOS 11, etc.") - do you want to make another PR to fix it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let me make one.

@divshacker
Copy link
Contributor Author

Just made one @imiric @na--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Github forms for issues
7 participants