-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Github forms #2174
New Github forms #2174
Conversation
divshacker
commented
Oct 11, 2021
@na--
|
Added Also I haven't found anything in PR template. Let me know your views. |
@na-- Please review this PR. |
@yorugac I have updated that. Let me know any further suggestions. |
Codecov Report
@@ Coverage Diff @@
## master #2174 +/- ##
==========================================
+ Coverage 72.71% 72.73% +0.01%
==========================================
Files 184 184
Lines 14571 14577 +6
==========================================
+ Hits 10596 10602 +6
Misses 3333 3333
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you!
Thanks! for approving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
- type: dropdown | ||
attributes: | ||
label: OS | ||
options: | ||
- Windows | ||
- Linux | ||
- Mac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry I'm late... Do we want to add an OS version input field? It might not be relevant in most cases, but it's good to know if someone's running on e.g. Windows XP 😄
Also maybe s/Mac/macOS/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm fair enough 😅 this should also probably be a separate free text field with examples (e.g. "Windows 10, Arch Linux, macOS 11, etc.") - do you want to make another PR to fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok let me make one.