Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js/k6: ModuleV2 migration #2242

Merged
merged 1 commit into from
Nov 22, 2021
Merged

js/k6: ModuleV2 migration #2242

merged 1 commit into from
Nov 22, 2021

Conversation

codebien
Copy link
Contributor

Migrated k6 to the modules.Module (aka modules.ModuleV2) interface.

@codebien codebien self-assigned this Nov 16, 2021
mstoykov
mstoykov reviewed Nov 16, 2021
View reviewed changes
js/modules/k6/k6.go Outdated Show resolved Hide resolved
yorugac
yorugac requested changes Nov 17, 2021
View reviewed changes
js/modules/k6/k6_test.go Outdated Show resolved Hide resolved
yorugac
yorugac approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@na-- na-- added this to the v0.36.0 milestone Nov 22, 2021
@codebien codebien merged commit e9ecfe7 into master Nov 22, 2021
@codebien codebien deleted the k6-modulev2 branch November 22, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorugac yorugac yorugac approved these changes

@mstoykov mstoykov mstoykov approved these changes

@na-- na-- Awaiting requested review from na--

Assignees

@codebien codebien

Labels
None yet
Projects
None yet
Milestone
v0.36.0
Development

Successfully merging this pull request may close these issues.
4 participants
@codebien @mstoykov @yorugac @na--